You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR primarily focuses on converting several synchronous serializeTransaction and related functions to asynchronous versions using await, enhancing the handling of promises throughout the codebase.
Detailed summary
Updated serializeTransaction functions to be asynchronous.
Changed function calls in various tests and utilities to use await.
Adjusted test cases to handle asynchronous behavior.
Updated usage of getL2TransactionHashes and getL2TransactionHash to be asynchronous.
Modified toSinglesigSmartAccount and toMultisigSmartAccount to return promises.
The following files were skipped due to too many changes: src/utils/transaction/serializeTransaction.test.ts
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This would be a large breaking change. What exactly is your use case? Maybe we can find an alternate approach that doesn’t require changes to Viem. For example, you could define a custom account that overrides signTransaction.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow transaction serializers to be async
PR-Codex overview
This PR primarily focuses on converting several synchronous
serializeTransactionand related functions to asynchronous versions usingawait, enhancing the handling of promises throughout the codebase.Detailed summary
serializeTransactionfunctions to be asynchronous.await.getL2TransactionHashesandgetL2TransactionHashto be asynchronous.toSinglesigSmartAccountandtoMultisigSmartAccountto return promises.